Skip to content

sea: print error information when fs operations fail #61581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
joyeecheung wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sea: print error information when fs operations fail #61581

joyeecheung wants to merge 2 commits into from
+9 −5

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Jan 29, 2026 •
edited
Loading

Refs: #61579

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 29, 2026

Review requested:

  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications labels Jan 29, 2026
richardlau
richardlau approved these changes Jan 29, 2026
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this testable (e.g. passing a non-existent binary in the config?)?

@codecov
Copy link

codecov bot commented Jan 29, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.76%. Comparing base (68d7b6f) to head (905a22e).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sea_bin.cc 50.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61581      +/-   ##
==========================================
- Coverage   89.77%   89.76%   -0.02%     
==========================================
  Files         673      673              
  Lines      203820   203864      +44     
  Branches    39175    39189      +14     
==========================================
+ Hits       182987   183006      +19     
- Misses      13152    13187      +35     
+ Partials     7681     7671      -10
Files with missing lines Coverage Δ
src/node_sea_bin.cc 41.72% <50.00%> (+0.12%) ⬆️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 30, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71133/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 31, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/71140/

@alexsch01
Copy link
Contributor

alexsch01 commented Jan 31, 2026

This is a good change and also my issue is more to do with missing command prompt detection: #61579 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@richardlau richardlau richardlau approved these changes

@legendecas legendecas legendecas approved these changes

+1 more reviewer

@aymen94 aymen94 aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@joyeecheung @nodejs-github-bot @alexsch01 @lpinca @UlisesGascon @richardlau @legendecas @aymen94